-
Notifications
You must be signed in to change notification settings - Fork 162
Support optional "inplace" iteration for Combinations/Multicombinations #5530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
So if I understand correctly, the "inplace" kwarg only exists for the case of Could you add the new kwarg to the two respective docstrings? |
I don't believe it makes sense, or at the very least would not be possible without more extensive changes; I would have to think about how to accomplish this, we don't get it for "free" from the Do we want the kwarg in the docstrings? |
Two good points, then better leave it like it is (at least for now). But could you please add a test that makes use of the new kwarg? |
Co-authored-by: Lars Göttgens <[email protected]>
Co-authored-by: Max Horn <[email protected]>
|
As long as all the tests still pass after my most recent change, I think this is ready to merge; I will open an issue to bring up the discussion of |
For use cases that benefit, we provide an option to have inplace versions of the iterators for
combinations(n,k)andmulticombinations(n,k)using an optionalinplacekeyword.Closes #4993